Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Example: Do not use monitoring endpoint #4726

Closed
wants to merge 2 commits into from
Closed

Interactive Example: Do not use monitoring endpoint #4726

wants to merge 2 commits into from

Conversation

matej-g
Copy link
Collaborator

@matej-g matej-g commented Oct 1, 2021

Signed-off-by: Matej Gera matejgera@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

See #4642 - the interactive test cannot run on MacOS due to upstream issue (usage of package available only for Linux platform). This is only due to usage of e2emonitoring package, which is however not necessary for running the interactive example. In order to make the example accessible to more users, I'd suggest to remove the monitoring endpoint for now.

Verification

Waiting on final verification from an Apple user 😅

@matej-g
Do not use monitoring endpoint
78cce83 
Signed-off-by: Matej Gera <matejgera@gmail.com>
@matej-g matej-g mentioned this pull request Oct 1, 2021
Closed
@matej-g
Update docs
d8c2169 
Signed-off-by: Matej Gera <matejgera@gmail.com>
@bwplotka
Copy link
Member

bwplotka commented Oct 7, 2021

))))))))))))))))))))))))))))))))))))))))))):

How hard is to fix e2emonitoring to support Mac? 🤔

@matej-g
Copy link
Collaborator Author

matej-g commented Oct 8, 2021

))))))))))))))))))))))))))))))))))))))))))):

How hard is to fix e2emonitoring to support Mac? thinking

I given it some more thought in efficientgo/e2e#15 (comment), but this would be the quickest and simplest way to unblock users for now.

yeya24
yeya24 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM and I think I can run it locally on MAC now.

@yeya24
Copy link
Contributor

yeya24 commented Oct 14, 2021

Another problem I got is related to thanosbench I guess.

Re-creating data (can take minutes)...
    interactive_test.go:96: interactive_test.go:96:
        
         unexpected error: level=info ts=2021-10-14T08:32:13.8579497Z caller=block.go:94 msg="generating block" spec="[1626739200001 - 1626746400000](1h59m59.999s) "
        level=info ts=2021-10-14T08:32:13.8638713Z caller=head.go:644 msg="Replaying on-disk memory mappable chunks if any"
        level=info ts=2021-10-14T08:32:13.8642123Z caller=head.go:658 msg="On-disk memory mappable chunks replay completed" duration=6.7µs
        level=info ts=2021-10-14T08:32:13.8642599Z caller=head.go:660 msg="WAL not found"
        level=info ts=2021-10-14T08:32:15.1394109Z caller=writer.go:123 msg=flushing series_count=10000 mint=2021-07-20T00:00:15.001Z maxt=2021-07-20T02:00:00.001Z
        level=info ts=2021-10-14T08:32:15.4804691Z caller=compact.go:494 msg="write block" mint=1626739215001 maxt=1626746400002 ulid=01FHYYWCS3VKFY8Z63HG7X358W duration=340.7427ms
        level=info ts=2021-10-14T08:32:15.5008466Z caller=block.go:100 msg="generated block" path=/shared/01FHYYWCS3VKFY8Z63HG7X358W count=1
        level=info ts=2021-10-14T08:32:15.5351131Z caller=block.go:94 msg="generating block" spec="[1626732000002 - 1626739200001](1h59m59.999s) "
        level=info ts=2021-10-14T08:32:15.5435799Z caller=head.go:644 msg="Replaying on-disk memory mappable chunks if any"
        level=info ts=2021-10-14T08:32:15.5551699Z caller=head.go:658 msg="On-disk memory mappable chunks replay completed" duration=11.4857ms
        level=info ts=2021-10-14T08:32:15.5553143Z caller=head.go:660 msg="WAL not found"
        level=info ts=2021-10-14T08:32:16.5731814Z caller=writer.go:123 msg=flushing series_count=10000 mint=2021-07-19T22:00:15.002Z maxt=2021-07-20T00:00:00.002Z
        level=info ts=2021-10-14T08:32:16.8511302Z caller=compact.go:494 msg="write block" mint=1626732015002 maxt=1626739200003 ulid=01FHYYWE5XG4S95ENH43WDKBWM duration=277.8265ms
        level=info ts=2021-10-14T08:32:16.8785436Z caller=block.go:100 msg="generated block" path=/shared/01FHYYWE5XG4S95ENH43WDKBWM count=2
        level=info ts=2021-10-14T08:32:16.9448842Z caller=block.go:94 msg="generating block" spec="[1626724800003 - 1626732000002](1h59m59.999s) "
        level=info ts=2021-10-14T08:32:16.9566276Z caller=head.go:644 msg="Replaying on-disk memory mappable chunks if any"
        level=error ts=2021-10-14T08:32:16.9739636Z caller=head.go:649 msg="Loading on-disk chunks failed" err="iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:16.9742048Z caller=head.go:760 msg="Deleting mmapped chunk files"
        level=info ts=2021-10-14T08:32:16.9742587Z caller=head.go:763 msg="Deletion of mmap chunk files failed, discarding chunk files completely" err="cannot handle error: iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:16.9743017Z caller=head.go:658 msg="On-disk memory mappable chunks replay completed" duration=17.294ms
        level=info ts=2021-10-14T08:32:16.9743268Z caller=head.go:660 msg="WAL not found"
        level=info ts=2021-10-14T08:32:17.9328488Z caller=writer.go:123 msg=flushing series_count=10000 mint=2021-07-19T20:00:15.003Z maxt=2021-07-19T22:00:00.003Z
        level=info ts=2021-10-14T08:32:18.1415243Z caller=compact.go:494 msg="write block" mint=1626724815003 maxt=1626732000004 ulid=01FHYYWFGCM4JE0ZWW12BPSF1D duration=208.5155ms
        level=info ts=2021-10-14T08:32:18.162202Z caller=block.go:100 msg="generated block" path=/shared/01FHYYWFGCM4JE0ZWW12BPSF1D count=3
        level=info ts=2021-10-14T08:32:18.2059675Z caller=block.go:94 msg="generating block" spec="[1626696000004 - 1626724800003](7h59m59.999s) "
        level=info ts=2021-10-14T08:32:18.2148509Z caller=head.go:644 msg="Replaying on-disk memory mappable chunks if any"
        level=error ts=2021-10-14T08:32:18.226069Z caller=head.go:649 msg="Loading on-disk chunks failed" err="iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:18.2261352Z caller=head.go:760 msg="Deleting mmapped chunk files"
        level=info ts=2021-10-14T08:32:18.2261555Z caller=head.go:763 msg="Deletion of mmap chunk files failed, discarding chunk files completely" err="cannot handle error: iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:18.2261738Z caller=head.go:658 msg="On-disk memory mappable chunks replay completed" duration=11.2182ms
        level=info ts=2021-10-14T08:32:18.2261903Z caller=head.go:660 msg="WAL not found"
        level=info ts=2021-10-14T08:32:24.5853101Z caller=writer.go:123 msg=flushing series_count=10000 mint=2021-07-19T12:00:15.004Z maxt=2021-07-19T20:00:00.004Z
        level=info ts=2021-10-14T08:32:25.635878Z caller=compact.go:494 msg="write block" mint=1626696015004 maxt=1626724800005 ulid=01FHYYWP0KWB2KB4E1P754BKN3 duration=1.0408006s
        level=info ts=2021-10-14T08:32:26.1911103Z caller=block.go:100 msg="generated block" path=/shared/01FHYYWP0KWB2KB4E1P754BKN3 count=4
        level=info ts=2021-10-14T08:32:26.4135318Z caller=block.go:94 msg="generating block" spec="[1626667200005 - 1626696000004](7h59m59.999s) "
        level=info ts=2021-10-14T08:32:26.4363701Z caller=head.go:644 msg="Replaying on-disk memory mappable chunks if any"
        level=error ts=2021-10-14T08:32:26.4554892Z caller=head.go:649 msg="Loading on-disk chunks failed" err="iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:26.4555625Z caller=head.go:760 msg="Deleting mmapped chunk files"
        level=info ts=2021-10-14T08:32:26.4561664Z caller=head.go:763 msg="Deletion of mmap chunk files failed, discarding chunk files completely" err="cannot handle error: iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:26.456323Z caller=head.go:658 msg="On-disk memory mappable chunks replay completed" duration=19.8364ms
        level=info ts=2021-10-14T08:32:26.4563441Z caller=head.go:660 msg="WAL not found"
        level=info ts=2021-10-14T08:32:31.7804892Z caller=writer.go:123 msg=flushing series_count=10000 mint=2021-07-19T04:00:15.005Z maxt=2021-07-19T12:00:00.005Z
        level=info ts=2021-10-14T08:32:32.4685814Z caller=compact.go:494 msg="write block" mint=1626667215005 maxt=1626696000006 ulid=01FHYYWX163E945QV6EV6Y11P1 duration=685.2956ms
        level=info ts=2021-10-14T08:32:32.503804Z caller=block.go:100 msg="generated block" path=/shared/01FHYYWX163E945QV6EV6Y11P1 count=5
        level=info ts=2021-10-14T08:32:32.6245474Z caller=block.go:94 msg="generating block" spec="[1626494400006 - 1626667200005](47h59m59.999s) "
        level=info ts=2021-10-14T08:32:32.6411135Z caller=head.go:644 msg="Replaying on-disk memory mappable chunks if any"
        level=error ts=2021-10-14T08:32:32.6537893Z caller=head.go:649 msg="Loading on-disk chunks failed" err="iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:32.6540151Z caller=head.go:760 msg="Deleting mmapped chunk files"
        level=info ts=2021-10-14T08:32:32.654074Z caller=head.go:763 msg="Deletion of mmap chunk files failed, discarding chunk files completely" err="cannot handle error: iterate on on-disk chunks: out of sequence m-mapped chunk for series ref 8"
        level=info ts=2021-10-14T08:32:32.6543796Z caller=head.go:658 msg="On-disk memory mappable chunks replay completed" duration=13.145ms
        level=info ts=2021-10-14T08:32:32.6545955Z caller=head.go:660 msg="WAL not found"
        : exit status 137

@matej-g
Copy link
Collaborator Author

matej-g commented Oct 14, 2021

We actually won't need this PR anymore, the upstream issue has been fixed - efficientgo/e2e#15

I will open a new PR, now we just need to bump the version.

As for the thanosbench, I'm not sure 🤔. I'm wondering if that was ever tested on MacOS as well.

@matej-g
Copy link
Collaborator Author

matej-g commented Oct 14, 2021

Closing this in favor of #4779, please take a look!

@matej-g matej-g closed this Oct 14, 2021
@saswatamcode saswatamcode mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matej-g @bwplotka @yeya24